Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module "classnames" definition does not support ES6 module definition #9003

Closed
1 task done
ArtemZag opened this issue Apr 15, 2016 · 3 comments
Closed
1 task done

Module "classnames" definition does not support ES6 module definition #9003

ArtemZag opened this issue Apr 15, 2016 · 3 comments

Comments

@ArtemZag
Copy link
Contributor

ArtemZag commented Apr 15, 2016 •
edited

  • I tried using the latest classnames/classnames.d.ts file in this repo and had problems.

image

As I result I get message "Module 'classnames' has no default export".
@vvakame
Copy link
Member

vvakame commented Apr 17, 2016

you should use import * as classnames from "classnames";.
https://github.com/JedWatson/classnames/blob/master/index.js#L39

@ArtemZag
Copy link
Contributor Author

@vvakame, Thanks. I'll try. The strange thing is that this also works:

import classnames from 'classnames';

I get typescript error but everything works.

@ohanar ohanar mentioned this issue May 4, 2016
Closed
@alexey-pelykh
Copy link
Contributor

Time to get back to this due to original package change: PR #25205 or PR #25206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

classnames: support es6 imports ohanar/DefinitelyTyped
3 participants
@vvakame @alexey-pelykh @ArtemZag