[@types/yargs] Yargs type for default might be wrong

[davidmurdoch]

Currently the inferred types comes from:

            // Use the type of `default` as the last resort
            : O extends ({ default: infer D }) ? Exclude<D, undefined>

see: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ba6c5b11a9d9ff910766625d58a45743a70f6503/types/yargs/index.d.ts#L931C17-L931C17

But I think this should be something like:

        // Use the type of `default` as the last resort
        : O extends (
            { default: infer D }
        ) ? D extends (
            (...args: any) => any
        // since default is a function, use its return type
        ) ? Exclude<ReturnType<D>, undefined>
        : Exclude<D, undefined>

but I'm not 100%. Hopefully someone with know-how knows more.

[Akiyamka]

It seems related yargs/yargs#2292