New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the repo? #5040
Comments
+1 |
1 similar comment
+1 |
I can do a PR if needed but that will break all existing PRs obviously |
Some other day.
What do you mean? |
Basically having _ a b c d ... z as the first folders of the repo and putting libs into those folder depending on their first letter such as: a
|_ angular
|_ ace
....
j
|_ jquery
... |
There are a couple of issues that discuss this What I proposed ( in #2150 ) was to split every definition file to a separate repo and use a central server to register repos as a definition file. ( #2150 (comment) ). Similar to the way NPM works. IMHO this is inevitable, because the benefits of centralising so much developer's work under one repo is not going to scale, not only in terms of repo-access, but also Issue tracking, releases, maintenance, etc. Maybe TypeScript team will also suggest a solution for this. |
I agree with @drinchev that having all the libs in the same repos can't scale really in terms of issues/PR but having one new repo for each seems a bit overkill to manage. Maybe splitting them by letters at the repo level? ie definitions-a, definitions-b @basarat that's easily doable by script |
Having it all in one repo has been working well in terms of providing a consistent user experience e.g. many defs depend on jquery or node ... splitting these out to different projects increases chances of a version conflict in user downloads and causes issues in tools.
Indeed, the difficult part is updating all the tools / test frameworks ... there needs to be a strong motivation |
Great to see that the repository had moved to the DefinitelyTyped Company! Kudos! |
I think this started to happen. TSD is being deprecated in favor of https://github.com/typings/typings . They separate the typings in different repos https://github.com/typings . |
I'm using Nuget with visual studio, currently all the links are pointing here. I hope this typing project will take ownership of the definitely typed code. as a side note, another distribution system of code is redundant as far as I'm concerned - Nuget, npm, bower are enough... |
I think the DefinitelyTyped should be split into separate individual repositories. It is so large now that Travis builds takes hours to complete. It would be much easier to contribute to smaller repositories and maintain it. |
it is not the repo organization that is to blame here. We have done it in a wrong way for Types-2.0, and we run all the tests all the time. which is frankly stupid. @andy-ms should be fixing this and going back to running it only on changed modules, like it works in master today. in master it takes a few minutes for a typical change. Repo reorganization is a valid discussion, but i just want to make it clear that CI performance has nothing to do with it. |
Sounds great, that will help with Types-2.0 a lot. |
@mhegazy : That sound great to run the test only on the folders that has been updated. On the other hand, this method can brings another problem: if the TypeScript compiler change, we should also run the tests on the whole repo. That is the error we got today due to a change in the TypeScript compiler, one of the library stops working while nothing change (#12434) To avoid this kind of issue, maybe we should stop using the nightly build of TypeScript inside the tests, but use the latest release instead. |
At this point, there's over a thousand not showing up. Can't this be split into a-z? It's admittedly hard to find particular packages now - I only got to Node's because I knew the format. |
You can press |
I'd like to contribute for new type definitions, but my IDE does not respect this project :( |
We need to support the ability of packages to reference each other using To find a file on github you can press |
I'm not sure I follow the |
The discussion on that is in microsoft/types-publisher#4. I know people don't like a big repo, but managing 1 repo with 3000 subdirectories is way easier than managing 3000 repos. See also babel. |
Well I generally agree with @blakeembrey in the discussion you linked. |
Idea: use dedicated repos for individual typings like what Typings uses, and have a registry of versioned symlinks to each repository URL + commit/tag/etc. The registry would be housed in a separate branch here, and the default branch would be changed to the registry branch. The existing This would improve people's workflow here tremendously while avoiding breaking things. BTW, we already do that in Mithril (front-end framework) to regen the bundle on commits to |
Hey,
The current architecture for the repo does not really scale well for the number of typings there is now.
How about a a-z-other structure to clean it up a bit ?
I think I remember reading something about it but couldn't find the issue again
The text was updated successfully, but these errors were encountered: