Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/ol] Last update broken #47778

Closed
mhosman opened this issue Sep 18, 2020 · 8 comments
Closed

[@types/ol] Last update broken #47778

mhosman opened this issue Sep 18, 2020 · 8 comments

Comments

@mhosman
Copy link

mhosman commented Sep 18, 2020

ERROR in node_modules/@types/ol/Geolocation.d.ts:77:24 - error TS2304: Cannot find name 'GeolocationPositionError'.

jakob-fyi added a commit to jakob-fyi/DefinitelyTyped that referenced this issue Sep 20, 2020
@timbru31
Copy link
Contributor

Ping @hanreev as the code owner of this typings.

@hanreev
Copy link
Contributor

hanreev commented Sep 26, 2020

It is TypeScript 4.1 changes, use previous version if you are using TypeScript < 4.1
#47681

@timbru31
Copy link
Contributor

Thanks for the pointer!

@gongAll
Copy link

gongAll commented Sep 28, 2020

Just a small reminder for next releases: Only release breaking changes like this whenever Typescript is also officially released, since 4.1.0 is still only the "next" version. Great job tho :)

@th30d0r
Copy link

th30d0r commented Oct 5, 2020

I cannot seem to find a stable version. My system runs on typescript 3.4.5 and any versions of this fails to compile with the above error

@dw-bayer
Copy link

dw-bayer commented Oct 7, 2020

add this bad boy to your tsconfig to jump over the issue.

{
  "compilerOptions": {
    "skipLibCheck": true
  },
}

@timbru31
Copy link
Contributor

This has been fixed in #49172, can this be closed?

@mhosman
Copy link
Author

mhosman commented Jan 19, 2021

Yeah, it seems it's working now. Closing. Thank you!

@mhosman mhosman closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants