[@types/node] ts4.8\events.d.ts(106,43): Error TS2370: Build:A rest parameter must be of an array type.

[raj-kumar]

[@types\node] latest release is breaking the build.

The ado build using visual studio 2022 is failing on version 20.11.24 with error:
node_modules@types\node\ts4.8\events.d.ts(106,43): Error TS2370: Build:A rest parameter must be of an array type.

tsconfig:

{
  "extends": "",
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./../dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "module": "es2015",
    "strictPropertyInitialization": false,
    "strict": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "skipLibCheck": true,
    "types": [],
    "target": "es5",
    "typeRoots": [
      "node_modules/@types",
      "./node_modules/@types"
    ],
    "lib": [
      "es2017",
      "dom"
    ]
  },
  "exclude": [
    "node_modules",
    "node_modules/@types",
    "wwwroot",
    "scripts",
    "src/scripts"
  ]
}

It works fine with old version. I tested by overriding:

{
  "overrides": {
    "@types/node": "17.0.41"
  }
}

[typescript-bot]

Thanks for the discussion about "node", some useful links for everyone:

• npm
• DT
• Related discussions

Pinging the DT module owners: @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky.

[peterblazejewicz]

/cc @malthe (owner of implementation change)

[malthe]

@raj-kumar what version of tsc is this?

How is this ADO build different than the ones running here in the CI workflow?

[raj-kumar]

It is set to ^4.8.4

package.json:

{
  "dependencies": {
    "@types/node": "^20.11.24",
    "child_process": "^1.0.2",
    "del": "^6.1.1",
    "documentation": "^14.0.2",
    "gulp": "^4.0.2",
    "gulp-concat": "^2.6.1",
    "gulp-debug": "^4.0.0",
    "gulp-flatten": "^0.4.0",
    "gulp-help": "^1.6.1",
    "gulp-if": "^3.0.0",
    "gulp-less": "^5.0.0",
    "gulp-load-plugins": "^2.0.8",
    "gulp-plumber": "^1.2.1",
    "gulp-rename": "^2.0.0",
    "gulp-sequence": "^1.0.0",
    "gulp-shell": "^0.8.0",
    "gulp-sourcemaps": "^3.0.0",
    "gulp-typescript": "^5.0.1",
    "gulp-uglify": "^3.0.2",
    "ts-node": "^10.9.1",
    "tslint": "^6.1.3",
    "typescript": "^4.8.4"
  },
  "devDependencies": {
    "gulp-minify": "^3.1.0"
  }
}

I am not sure how build is different, but we use Visual studio task to build it ADO pipeline, and it stared failing on Feb 20th:

[malthe]

@raj-kumar I can reproduce the error only with TypeScript 4.5.5 – see playground.

With any later version, the issue goes away. Are you sure this is compiled with 4.8.4?

[raj-kumar]

Oh, I think it is using 4.3 on build agent. But still, it should not fail, the changes should be backward compatible?

[malthe]

The CI currently doesn't test lower than 4.6.

I suppose there's a lower limit, but I'm not sure it's made explicit by the maintainers. Probably?

[malthe]

Only two years of TypeScript is supported:

[malthe]

@peterblazejewicz recommend we close this discussion because it concerns an older version which we no longer support.

[dampee]

For those using nuget packages (in visual studio), if you have the Microsoft.TypeScript.MSBuild nuget package, you probably need to upgrade.