Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom_feature="symbol" is only available for class GCPNGeneration() ? #240

Open
teltim opened this issue Nov 30, 2023 · 1 comment
Open

Comments

@teltim
Copy link

teltim commented Nov 30, 2023

     ...
    @torch.no_grad()
    def generate(self, num_sample, max_resample=20, off_policy=False, max_step=30 * 2, initial_smiles="C", verbose=0):
        is_training = self.training
        self.eval()
        graph = data.Molecule.from_smiles(initial_smiles, kekulize=True, atom_feature="symbol").repeat(num_sample)
     ...

Is there any use for limiting the graph features during generation to symbols?
Does this mean that generation will not work for anything other than symbols?

Actually, reonforcement_learning can finish in less than a long time for "symbols."
But, it can spend long time with, for instance, "explicit_property_prediction".
I do not know the reason...

@teltim teltim changed the title class GCPNGeneration(tasks.Task, core.Configurable): atom_feature="symbol" is only available for class GCPNGeneration() ? Nov 30, 2023
@chrisvdwerf
Copy link

I noticed that, when splitting up finalized molecular graphs into subgraphs, there is no refeaturization in the torchdrug implementation of GCPN.

For some features this can be troublesome, e.g. number of implicit hydrogen atoms, as these node features depend on neighbourhood of a node.

As such, I think that you should be careful about which features you include in the node embeddings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants