Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug on adding products when all removed - APM-0, APM-1, APM-2 #51

Open
dekideian opened this issue Aug 23, 2021 · 2 comments
Open

Comments

@dekideian
Copy link

Hello,

Really appreciate your work and your courses. Kudos! :)

Found a small bug, when all the products are removed, it is not possible to add a new one without explicitly mentioning an id.
Have the fix on a separate branch ready for PR, cannot push it sadly, 403.

Best regards,
Deian

@dekideian
Copy link
Author

Opened a PR #52 :). Realized I can fork the repo and then I can push a branch and open a PR.

@duncanhunter
Copy link
Collaborator

Hi

You rock for taking the time to point this out!

I agree with you in a more real-world example you would guard for this. I would love to accept a PR to fix it and you are kind to offer but we strive to keep the code and the video in sync. For this reason, I do not think we should change it until the next course update. I have tagged this issue to address when we do the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants