Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all missing data #70

Open
DavideViolante opened this issue Sep 21, 2022 · 3 comments
Open

Add all missing data #70

DavideViolante opened this issue Sep 21, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@DavideViolante
Copy link
Owner

Seems like this project has all possible inputs for investing.com:
https://github.com/alvarobartt/investpy/tree/master/investpy/resources

Expand mapping.js with all these csv, then add info about source in readme.

@DavideViolante DavideViolante added the enhancement New feature or request label Sep 21, 2022
@yortug
Copy link

yortug commented Oct 7, 2022

😮

What a good find!!

Any ideas on how we'd go about adding all of these CSVs into this repo?

A simple way could be to pull those CSVs into this repo (somehow), then write a simple JS script that reads in all of these CSVs, converts them to JSON, and then outputs the JSON into some file that the mapping.js file can export?

The part I'm unsure about is how we pull in those CSVs from the other repo? And, preferably we'd want to do this in a way where we could update the CSVs potentially (if we want to add any more data), but also we'd want to always be using the most up-to-date version of these CSVs within the investpy repo too?

Any ideas on how to get that done? If I get some guidance, I can probably work on implementing this enhancement. 👍🏻

@DavideViolante
Copy link
Owner Author

The CSV are from ~2-3 years ago so I think they don't change so much during time. I was thinking not to use CSV format but download and convert these files into JSON and add all the info in mapping.js.

@DavideViolante DavideViolante self-assigned this Oct 7, 2022
@DavideViolante
Copy link
Owner Author

Update: since v4.3.0 the library accept a pairId as input, even if the pairId is not present in mapping.js. This allows to use ANY valid pairId from Investing.com website.

@DavideViolante DavideViolante removed their assignment May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants