-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all missing data #70
Comments
😮 What a good find!! Any ideas on how we'd go about adding all of these CSVs into this repo? A simple way could be to pull those CSVs into this repo (somehow), then write a simple JS script that reads in all of these CSVs, converts them to JSON, and then outputs the JSON into some file that the The part I'm unsure about is how we pull in those CSVs from the other repo? And, preferably we'd want to do this in a way where we could update the CSVs potentially (if we want to add any more data), but also we'd want to always be using the most up-to-date version of these CSVs within the Any ideas on how to get that done? If I get some guidance, I can probably work on implementing this enhancement. 👍🏻 |
The CSV are from ~2-3 years ago so I think they don't change so much during time. I was thinking not to use CSV format but download and convert these files into JSON and add all the info in mapping.js. |
Update: since v4.3.0 the library accept a pairId as input, even if the pairId is not present in mapping.js. This allows to use ANY valid pairId from Investing.com website. |
Seems like this project has all possible inputs for investing.com:
https://github.com/alvarobartt/investpy/tree/master/investpy/resources
Expand mapping.js with all these csv, then add info about source in readme.
The text was updated successfully, but these errors were encountered: