You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My thoughts are that the default return value probably shouldn't be the high or the low values, so it shouldn't be set to item[2] or item[3], as they could fluctuate heavily on a high volatity day of trading.
However, it's a bit harder to decide whether it should be the open or the close price (i.e. should it be item[1] or item[4]?).
We have value set as the open price at the moment (i.e. item[1]).
I personally think the close price (i.e. item[4]) would be the safest option in terms of the data understanding. When you query the close price, and the market is still open, you'd expect (hope) the API simply wouldn't return a result. This might give the end user a clue as to what price they actually are working with, they aren't getting a return value for the current day because the market hasn't closed yet.
However, I do think that the open price (i.e. item[1]) has its advantages too. It has the benefit of (hopefully) returning a value even if the market hasn't closed yet.
TL;DR - My opinion is that item[1] and item[4] would be fine, I'd say item[4] has the slight edge, but it's really up to the end user's intended use case / understanding. As long as the end user knows which value they are utilising, and has access to all the other values too (as they do now), then I don't think we can go too wrong! 😁
See discussion in #61
After the mentioned PR this package is returning also some other values, see readme.
The text was updated successfully, but these errors were encountered: