Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Directivity #16

Closed
schmiph2 opened this issue Nov 2, 2020 · 5 comments · Fixed by #28 · May be fixed by #27
Closed

Source Directivity #16

schmiph2 opened this issue Nov 2, 2020 · 5 comments · Fixed by #28 · May be fixed by #27
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@schmiph2
Copy link

schmiph2 commented Nov 2, 2020

Hi David

Thank you for this great library! Do you have plans to include the directivity of the sources in the library? Would it even be possible to add them to your library?
@DavidDiazGuerra
Copy link
Owner

Hi schmiph2,

Including non omnidirectional sources in the library is a great idea, but I'm afraid I don't have time time to implement it in the near future. Nevertheless, if anyone wants to try to do it, it should be possible and, actually, not too difficult.

The directivity of the receiver is included in:

gpuRIR/src/gpuRIR_cuda.cu

Line 342 in c1279cd

amp *= mic_directivity(vec, &sh_orV_rcv[m_rcv], mic_pattern);

through the function mic_directivity:

gpuRIR/src/gpuRIR_cuda.cu

Line 132 in c1279cd

__device__ __forceinline__ float mic_directivity(float doaVec[3], float orVec[3], micPattern pattern) {

This function first computes the angle between the steering vector of the microphone and the vector with the direction of arrival (DOA) of the image source and then apply the desired directivity pattern.

The directivity of the sources could be implemented in a similar way, but computing the angle bwtween the steering vector of the source (which should be added as a new parameter of the simulateRIR function) and the normal vector of the first reflection wall.

I'll try to implement it in the future if nobody does it before, but I don't know when I'll have time to do it.

@DavidDiazGuerra DavidDiazGuerra added enhancement New feature or request help wanted Extra attention is needed labels Nov 5, 2020
@schmiph2
Copy link
Author

schmiph2 commented Nov 17, 2020 •
edited

Hi David

Thank you for your answer an the hints for the implementing the source directivity and sorry for my late reply. I will check if I can find some time for the implementation. I will let you know if we start the implementation.

@catherine-qian
Copy link

Hi all
Thanks for the discussion on this issue. just wondered whether there is an existing RIR generator that can simulate speaking head orientation?

@DavidDiazGuerra
Copy link
Owner

Hi Catherine,

Pyroomacoustics is one of the most comprehensive acoustic simulation libraries for Python, but I don't know if it includes that feature.

@catherine-qian
Copy link

thanks for your reply！

@fuerbringer fuerbringer mentioned this issue Dec 15, 2021
Open
@corrooli corrooli mentioned this issue Dec 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@catherine-qian @schmiph2 @DavidDiazGuerra