Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issues with column name escaping approach #168

Closed
DVAlexHiggs opened this issue Oct 28, 2022 · 3 comments
Closed

[BUG] Issues with column name escaping approach #168

DVAlexHiggs opened this issue Oct 28, 2022 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@DVAlexHiggs
Copy link
Member

DVAlexHiggs commented Oct 28, 2022

Describe the bug

A feature we released back in 0.8.0 has been causing some problems ever since: Column Name Escaping.

We originally implemented this to account for problem columns coming from source data, such as reserved words and columns with spaces in them.

We are re-thinking the design of this as it is having unexpected consequences and is becoming painful to maintain.

Essentially, we will be stripping all use of column escaping from everywhere but staging, and even then will only provide the functionality through a toggle. This toggle already exists and is well documented.

This should have been how it was implemented from the start, and we apologise for any inconvenience this has caused!

Bug reports

We've had a lot of community feedback on this issue, so your issue may have already been raised, however if you feel you've found another case where this is causing problems, please submit another report.

The following existing bug reports are related to this issue:

@DVAlexHiggs DVAlexHiggs added the bug Something isn't working label Oct 28, 2022
@DVAlexHiggs DVAlexHiggs self-assigned this Oct 28, 2022
@DVAlexHiggs DVAlexHiggs changed the title [BUG] Issues with column name escaping [BUG] Issues with column name escaping approach Oct 28, 2022
@DVAlexHiggs DVAlexHiggs pinned this issue Oct 28, 2022
@DVAlexHiggs DVAlexHiggs added the enhancement New feature or request label Oct 28, 2022
@anouar-zh
Copy link

Hi! Any idea when you will release a new version?

@DVAlexHiggs
Copy link
Member Author

DVAlexHiggs commented Dec 14, 2022

@anouar-zh Good progress has been made on this and we should have all of these issues fixed in the next release (later this week). Thank you for your patience!

@DVAlexHiggs
Copy link
Member Author

0.9.1 Released which should address the majority of these problems. Thanks everyone for you patience! Please let us know if you continue to have issues

@DVAlexHiggs DVAlexHiggs unpinned this issue Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants