Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP PUT and PATCH Data and headers #2497

Open
nikalemdzievski opened this issue Jan 30, 2024 · 2 comments
Open

HTTP PUT and PATCH Data and headers #2497

nikalemdzievski opened this issue Jan 30, 2024 · 2 comments

Comments

@nikalemdzievski
Copy link

nikalemdzievski commented Jan 30, 2024

Describe the feature you'd like

We don't have PUT or PATCH data when span concerns PUT or PATCH requests.
There is a functionality for POST tho, so I was wondering if there was any specific reason why PUT and PATCH are not implemented.

Is your feature request related to a problem?

No

Describe alternatives you've considered

One can always add this data manually by extending the span but it will be nice to have this supported out of the box same as for POST requests.

@PROFeNoM
Copy link
Contributor

PROFeNoM commented Feb 1, 2024

Hello @nikalemdzievski!

Thank you for submitting your feature request 😃

Could you please provide some additional information to scope your request better? Specifically, can you share your use case for this feature? For example, are you using Guzzle? Additionally, what do you expect to see in the spans? Would something like http.patch.key -> val work for you?

I appreciate your help!

@nikalemdzievski
Copy link
Author

Hey @PROFeNoM !

thanks for getting back to me, I appreciate your patience.

This would come in handy when we wanna debug a particular request. Often the performance or bugs are isolated to specific users, resources, or parameters. For example, consider updating a user. There is a bunch of data that is coming in the body that is not visible on Datadog.
What I am hoping to see is the same functionality and format as the DD_TRACE_HTTP_POST_DATA_PARAM_ALLOWED functionality. Key http.patch.key -> val will work just fine. I think the current format for POST is something like this: http.request.key=value (based on the docs).

We use Laravel as a framework which uses Guzzle in the background.
Let me know if I can provide more information.

Thank you,
Nikola.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants