Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] pecl-amqp integration #2324

Open
redpanda opened this issue Oct 23, 2023 · 1 comment
Open

[Feature] pecl-amqp integration #2324

redpanda opened this issue Oct 23, 2023 · 1 comment

Comments

@redpanda
Copy link

redpanda commented Oct 23, 2023

Describe the feature you'd like

As a developer, I'd like to have traces for application that use the pecl-amqp extension.

Is your feature request related to a problem?

Some PHP applications that uses the php-amqplib library are natively instrumented (thanks to this request), but it is not the case on other applications that uses pecl-amqp extension.

Describe alternatives you've considered

I considered to implement an custom instrumentation for pecl-amqp extension, but I would like to know if this feature could be integrated in the dd-trace-php package.

About the feature considered, I'm seeing something similar to the native php-amqlib instrumentation, we could instrumented the following methods:

AMQPExchange

  • AMQPExchange::declareExchange ?
  • AMQPExchange::declare
  • AMQPExchange::publish

AMQPQueue

  • AMQPQueue::ack
  • AMQPQueue::bind
  • AMQPQueue::cancel
  • AMQPQueue::consume
  • AMQPQueue::declareQueue?
  • AMQPQueue::declare
  • AMQPQueue::get
  • AMQPQueue::nack

AMQPConnection

  • AMQPConnection::connect
  • AMQPConnection::pconnect
  • AMQPConnection::reconnect

Additional context

Thank you in advance for considering the request feature and let me know if we can give a hand to develop the feature. 👍

@bwoebi
Copy link
Collaborator

bwoebi commented Oct 24, 2023

Hey @redpanda,

Would be certainly nice to have. It's right now not on top of the priority list, but we wouldn't object to a PR :-)

About the to be instrumented methods, it should basically mirror what the php-amqplib integration also instruments. So at a first glance, the list of to be instrumented methods looks correct.

It would need a comprehensive testsuite as well though, like https://github.com/DataDog/dd-trace-php/blob/master/tests/Integrations/AMQP/AMQPTest.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants