Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats for contrib/jackc/pgxpool #2680

Open
bengentree opened this issue May 1, 2024 · 4 comments · May be fixed by #2692
Open

Stats for contrib/jackc/pgxpool #2680

bengentree opened this issue May 1, 2024 · 4 comments · May be fixed by #2692
Assignees
@mtoffl01
Labels
apm:ecosystem contrib/* related feature requests or bugs

Comments

@bengentree
Copy link

Basically the same request as #2303 but using the pgxpool stats to periodically report pool stats. Happy to contribute as well, thanks in advance.
@github-actions github-actions bot added apm:ecosystem contrib/* related feature requests or bugs needs-triage New issues that have not yet been triaged labels May 1, 2024
@mtoffl01 mtoffl01 self-assigned this May 2, 2024
@mtoffl01
Copy link
Contributor

mtoffl01 commented May 2, 2024 •
edited

Hello! I've been looking into this. Can you share how you configure the tracer to connect via UDS? What config options are you using, including env vars?
Thanks!

@bengentree
Copy link
Author

Hello! I've been looking into this. Can you share how you configure the tracer to connect via UDS? What config options are you using, including env vars? Thanks!

Hi, are you referring to the statsd connection? I configure the client using hostname:port for UDP currently.

@mtoffl01
Copy link
Contributor

mtoffl01 commented May 8, 2024

@bengentree ,
The existing DB Stats feature exists only on the database/sql contrib, we don't yet have support for other related integrations.
To clarify, are you using the database/sql integration, or the jackc/pgx.v5 integration?

@bengentree
Copy link
Author

@bengentree , The existing DB Stats feature exists only on the database/sql contrib, we don't yet have support for other related integrations. To clarify, are you using the database/sql integration, or the jackc/pgx.v5 integration?

I'm using the pgx integration, this feature request was to add pgxpool stats to the pgx integration similar to what was just done for database/sql contrib.

@darccio darccio removed the needs-triage New issues that have not yet been triaged label May 9, 2024
bengentree added a commit to bengentree/dd-trace-go that referenced this issue May 11, 2024
@bengentree
contrib/jackc/pgx.v5: publish pgxpool stats to statsd client
aa7795e 
Fixes DataDog#2680
@bengentree bengentree linked a pull request May 11, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtoffl01 mtoffl01

Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

contrib/jackc/pgx.v5: publish pgxpool stats to statsd client bengentree/dd-trace-go
3 participants
@darccio @mtoffl01 @bengentree