If dd-agent starts before cluster agent, cluster name returns empty

[harold-kfuse]

Agent Environment

I deployed datadog on an EKS cluster using Datadog 3.59.4 helm chart. It has agent/cluster version of 7.52.0

Describe what happened:

Cluster name returns empty

Describe what you expected:

kube_cluster_name should be detected

Steps to reproduce the issue:

Additional environment details (Operating System, Cloud provider, etc):

I did a little digging on the code base. I think it's due to this line:

datadog-agent/pkg/util/kubernetes/clustername/clustername.go

Line 139 in 3afaaa5

data.initDone = true

It sets initDone to true, regardless if the clustername detection succeeded. Is it better to set it to true only after it has actually succeeded. I'm assuming that if initDone is not true, the Dd-agent will retry.

I enabled debug logging and I saw that the detection fails because the agent was not able to talk to the cluster agent. This can happen, since helm install deploys both the agent and cluster agent at the same time and cluster agent may not have started before the agent.