Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some bugs in class DefaultPreprocessor #21

Open
CyrilZhao-sudo opened this issue Jul 25, 2020 · 1 comment
Open

some bugs in class DefaultPreprocessor #21

CyrilZhao-sudo opened this issue Jul 25, 2020 · 1 comment

Comments

@CyrilZhao-sudo
Copy link

Here, class DefaultPreprocessor, fit_transform method,
{if copy: # TODO bug here
X = copy.deepcopy(X)
y = copy.deepcopy(y)} . the copy may be copy_data.
@jackguagua
Copy link
Member

deepcopy is used to avoid (X,y) being changed by processor so that other tasks that rely on cannot obtain correct data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CyrilZhao-sudo @jackguagua