Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only views of joined data #18

Open
greentfrapp opened this issue May 8, 2022 · 3 comments
Open

Read-only views of joined data #18

greentfrapp opened this issue May 8, 2022 · 3 comments
Assignees
Milestone

Comments

@greentfrapp
Copy link
Contributor

No description provided.

@dreinon
Copy link

dreinon commented May 10, 2022

This is a nice feature since in SQL, an entity can be divided into different tables in order to avoid duplication

@greentfrapp greentfrapp self-assigned this Jun 6, 2022
@greentfrapp greentfrapp changed the title Support pages based on table joins Read-only views of joined data Jun 6, 2022
@greentfrapp greentfrapp added this to the Joins milestone Jun 6, 2022
@OneFishTwoFishRedFish-JFish
Copy link
Contributor

Hey @greentfrapp , playing around with this today. I think it's a good first pass, but can we make configuring a Join Attribute more explicit?

I get why you might not want to introduce a separate config object, but I think it would help someone know what's going on just by looking at the code or config - right now I have to rely on the example or dig into the code. A separate object might also prevent having to do all the regex and make it easier to add more options in the future.

Just my 2 cents :) let me know if you wanna discuss

@greentfrapp
Copy link
Contributor Author

Woops sorry @OneFishTwoFishRedFish-JFish I think this was automatically closed when I merged a PR that said "fixed 18"

Reopening for discussion - will take a closer look!

@greentfrapp greentfrapp reopened this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants