-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce reliance on variables passed to debug adapters #2783
Comments
@ericdallo FYI - as part of this work, I'm removing When most of these were added, VS Code was the only consumer so it was convenient to just pass them in. However, it's made using the debug adapter more complicated when many of the values could be computed by the debug adapter. This should simplify things a little (I'm also reviewing the defaults and making sure most of the values are entirely optional). (Note: Use of this debug adapter by non-VS Code clients isn't "officially" supported, though I would like to ensure it works and is not too burdensome! 🙂). |
Thank you very much @DanTup, I totally agree! |
Sorry for the delay @DanTup , I just bumped |
There are many variables passed into the
launchRequest
likedartVersion
andflutterVersion
that are only supplied by VS Code. In order to make the Debug Adapter more reusable, these things should be computed inside the debug adapter. All variables should also have sensible defaults.The text was updated successfully, but these errors were encountered: