-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back larger build/hot reload notifications #2597
Comments
Thanks for the report! There was a bug here, but also we adopted a new API in VS Code which unfortunately doesn't show progress notifications for 500ms, so very short progress notifications would not show at all. For now, I've reverted to handling the progress notifications ourselves. I'll push out a minor update shortly. Note - even with this change, the status will now show only in the status bar by default (not in a large notification as in your screenshot). This was requested by the VS Code team. |
|
@rajeshjeshar the new status notification should appear over on the left, and it should show "Hot reloading.." with a spinner. Once it completes, it should show Hot reload complete!" for a further 150ms. The goal is still to move to the debug-adapter-protocol status message once it's been improved, which gives us no ability to show a larger progress notification. We can do this with custom messages, but I'd really like to stick to the DAP spec so that the debugger is more portable. Therefore, if the current notifications are not obvious enough, I think it would be better to improve in DAP/VS Code. I'll add a note on microsoft/vscode#101405 about this. |
I've opened microsoft/vscode#101791 specifically for VS Code to consider support this with DAP messages. Please add a 👍 to microsoft/vscode#101791! |
hotreloading process is not showing in the notification bar,I did not updated the flutter sdk,but a few hours before the issue ive seen a notification about "Dart sdk has been updated".
completely uninstalled and recreated a new project but the issue remains same,Only when the hotlreload is finished its logged in console
"Reloaded 0 of 495 libraries in 167ms."
Expected Progress indication for hotreload is..
The text was updated successfully, but these errors were encountered: