Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back larger build/hot reload notifications #2597

Closed
ghost opened this issue Jun 30, 2020 · 4 comments
Closed

Bring back larger build/hot reload notifications #2597

ghost opened this issue Jun 30, 2020 · 4 comments
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is enhancement
Milestone

Comments

@ghost
Copy link

ghost commented Jun 30, 2020

hotreloading process is not showing in the notification bar,I did not updated the flutter sdk,but a few hours before the issue ive seen a notification about "Dart sdk has been updated".
completely uninstalled and recreated a new project but the issue remains same,Only when the hotlreload is finished its logged in console "Reloaded 0 of 495 libraries in 167ms."

Expected Progress indication for hotreload is..
85929623-1ac64380-b8d4-11ea-8a3f-2db99d40f4b0

@DanTup DanTup added this to the v3.12.1 milestone Jun 30, 2020
@DanTup DanTup added in debugger Relates to the debug adapter or process of launching a debug session is bug in flutter Relates to running Flutter apps labels Jun 30, 2020
@DanTup DanTup closed this as completed in 1fe5a81 Jun 30, 2020
@DanTup
Copy link
Member

DanTup commented Jun 30, 2020

Thanks for the report! There was a bug here, but also we adopted a new API in VS Code which unfortunately doesn't show progress notifications for 500ms, so very short progress notifications would not show at all.

For now, I've reverted to handling the progress notifications ourselves. I'll push out a minor update shortly.

Note - even with this change, the status will now show only in the status bar by default (not in a large notification as in your screenshot). This was requested by the VS Code team.

@ghost
Copy link
Author

ghost commented Jul 1, 2020

Untitled-1 copy
@DanTup Yes Dart code was updated to 3.12.1, and hotreload progress was shown in status bar as tiny notification bell as you said,
But for your reference,some times hotreload is not going to be finished less than 500ms,its average falls from 800ms to 3000ms depends upon the configuration,may be it is less than 500ms in mac but not in windows.
so please give it large progress notification bar as an optional choice to enable disable inside the settings.json ,this tiny indication is not visible

@DanTup
Copy link
Member

DanTup commented Jul 1, 2020

@rajeshjeshar the new status notification should appear over on the left, and it should show "Hot reloading.." with a spinner. Once it completes, it should show Hot reload complete!" for a further 150ms.

The goal is still to move to the debug-adapter-protocol status message once it's been improved, which gives us no ability to show a larger progress notification. We can do this with custom messages, but I'd really like to stick to the DAP spec so that the debugger is more portable.

Therefore, if the current notifications are not obvious enough, I think it would be better to improve in DAP/VS Code. I'll add a note on microsoft/vscode#101405 about this.

@DanTup DanTup modified the milestones: v3.12.1, Backlog Jul 6, 2020
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Jul 6, 2020
@DanTup DanTup changed the title Hot reloading is not indicated Bring back larger build/hot reload notifications Jul 6, 2020
@DanTup
Copy link
Member

DanTup commented Jul 6, 2020

I've opened microsoft/vscode#101791 specifically for VS Code to consider support this with DAP messages. Please add a 👍 to microsoft/vscode#101791!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

No branches or pull requests

1 participant