Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect touchbar keyboard ignore list #2195

Closed
JasCodes opened this issue Jan 1, 2020 · 4 comments
Closed

Respect touchbar keyboard ignore list #2195

JasCodes opened this issue Jan 1, 2020 · 4 comments
Labels
working as intended Described behaviour is expected.

Comments

@JasCodes
Copy link

JasCodes commented Jan 1, 2020

Allow to skip render of touch buttons when they are added to ignored list.

e.g

"keyboard.touchbar.ignored": [
        "flutter.screenshot",
		"workbench.action.navigateBack",
        "workbench.action.navigateForward",
        "workbench.action.debug.run",
        "workbench.action.debug.pause",
        "workbench.action.debug.stop",
    ],

The above shouldn't render screenshot button.
That allows me to have space for my other custom touch buttons which is not possible right now.

Thx

@JasCodes JasCodes changed the title Respect touchbar keyboard ingnore list Respect touchbar keyboard ignore list Jan 1, 2020
@DanTup
Copy link
Member

DanTup commented Jan 2, 2020

Thanks - I've opened an issue at microsoft/vscode#87980 asking for clarification on how this is intended to work. It feels unnecessary for every extension contributing buttons to implement this check when VS Code could do it itself so I'd like to ensure it's the correct thing before doing it (and if it is the correct thing, I've requested that it's documented).

@DanTup DanTup added this to the v3.8.0 milestone Jan 2, 2020
@DanTup DanTup added the blocked on vs code / lsp / dap Requires a change in VS Code to progress label Jan 2, 2020
@JasCodes
Copy link
Author

JasCodes commented Jan 2, 2020

Cool!!
Meanwhile can you create a simple option flutter.disableTouchbar to disable all buttons generated via dartcode extension?

Thx

@DanTup
Copy link
Member

DanTup commented Jan 2, 2020

There's no release planned until towards the end of the month, so I'd prefer to wait for a response on that issue before making any changes. If there's no response before the next release then I'll look at adding something (I've already put this issue into the current milestone so it's not missed).

@DanTup
Copy link
Member

DanTup commented Jan 4, 2020

Turns out this is working as expected, but in order to have shorter text ("Screenshot") on the touchbar than the command palette ("Save Screenshot") we have two have two commands. The ID of the command on the touchbar is _flutter.screenshot.touchBar. If you change to that, it works.

It's not ideal that you'd need to know the internal names of hidden commands (I've commented such on the issue above), but you can find them in the package.json file here.

Hope this helps!

@DanTup DanTup closed this as completed Jan 4, 2020
@DanTup DanTup added working as intended Described behaviour is expected. and removed blocked on vs code / lsp / dap Requires a change in VS Code to progress labels Jan 27, 2020
@DanTup DanTup removed this from the v3.8.0 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
working as intended Described behaviour is expected.
Projects
None yet
Development

No branches or pull requests

2 participants