Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support launching DevTools with the dark theme #1496

Closed
DanTup opened this issue Feb 28, 2019 · 4 comments
Closed

Support launching DevTools with the dark theme #1496

DanTup opened this issue Feb 28, 2019 · 4 comments
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Milestone

Comments

@DanTup
Copy link
Member

DanTup commented Feb 28, 2019

Similar to #1050.

@DanTup DanTup added this to the On Deck milestone Feb 28, 2019
@audkar
Copy link

audkar commented Mar 1, 2019

If we add support, it may have to be a user setting in VS Code to let you choose which theme you want?

Dark theme is worth my effort to change user setting manually :)

@DanTup DanTup closed this as completed in f4e9367 Mar 4, 2019
@DanTup DanTup modified the milestones: On Deck, v2.25.0 Mar 4, 2019
@DanTup
Copy link
Member Author

DanTup commented Mar 4, 2019

Dark theme will be default from vNext. There's a new setting that lets you set the theme:

"dart.theme": "light" // or "dark"

This controls both the icons in tooltips and the DevTools theme. If it turns out that people would like to use different themes for VS Code/icons than DevTools, we can add a separate setting in future.

@DanTup
Copy link
Member Author

DanTup commented Mar 12, 2019

Not totally happy with how the Dark theme looks right now, so undoing this and re-opening, and will re-evaluate before this version ships.

@DanTup DanTup reopened this Mar 12, 2019
DanTup added a commit that referenced this issue Mar 12, 2019
@DanTup DanTup closed this as completed in fa17317 Mar 18, 2019
@DanTup
Copy link
Member Author

DanTup commented Mar 18, 2019

There are two settings in vNext:

  • dart.theme (defaults to dark)
  • dart.devToolsTheme (defaults to light)

When the Dark Theme is more polished, I'll change the default of dart.devToolsTheme, but for now you can opt-in to it manually.

@DanTup DanTup added the in commands Relates to commands (usually invoked from the command Palette) label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Projects
None yet
Development

No branches or pull requests

2 participants