Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete removing preceding space #1483

Closed
mayorbyrne opened this issue Feb 26, 2019 · 5 comments
Closed

Autocomplete removing preceding space #1483

mayorbyrne opened this issue Feb 26, 2019 · 5 comments
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@mayorbyrne
Copy link

mayorbyrne commented Feb 26, 2019

When I try and set a value using autocomplete, sometimes the editor removes the preceding space. If I want something that looks like note.x = dropAreaBG.x, if I autocomplete on dropAreaBG, the end results looks like note.x =dropAreaBG.x.

I've added a gif that illustrates what I'm seeing. Since this doesn't seem to happen when editing js, it feels like a dart extension issue.

autocomplete gif

@DanTup DanTup added this to the v2.25.0 milestone Feb 26, 2019
@DanTup DanTup added is bug in editor Relates to code editing or language features labels Feb 26, 2019
@DanTup
Copy link
Member

DanTup commented Feb 26, 2019

Yep, definitely a bug! Possibly related to us putting a space in filterText (suggested at microsoft/vscode#66860 (comment)). I'll see what I can find. Thanks!

@DanTup
Copy link
Member

DanTup commented Feb 28, 2019

Unfortunately VS Code doesn't handle what we were trying to do here very well, so I've had to remove = and : as trigger completion characters. This means completion won't open automatically after typing those (but will when you type another character, or manually invoke with Ctrl+Space).

@alex9153
Copy link

I have the same problem. Is there any solution?

@DanTup
Copy link
Member

DanTup commented Apr 10, 2019

@alex9153 What version of the Dart extension do you have? This should be fixed in the latest release.

@alex9153
Copy link

Just updated to 2.25.0 ... seems like error is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

3 participants