Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions with types don't match functions without types' highlighting color #1385

Closed
lukepighetti opened this issue Jan 9, 2019 · 4 comments
Labels
in editor Relates to code editing or language features is bug
Milestone

Comments

@lukepighetti
Copy link

screen shot 2019-01-08 at 11 01 45 pm

I've noticed that functions and method with generics do not get the same color format as functions/methods without. Is this intentional? Is this a Dart-Code issue or an issue with my color palette?

Thank you!

@DanTup
Copy link
Member

DanTup commented Jan 9, 2019

Looks like a bug to me!

@DanTup DanTup added this to the v2.22.0 milestone Jan 9, 2019
@DanTup DanTup added is bug in editor Relates to code editing or language features labels Jan 9, 2019
@DanTup
Copy link
Member

DanTup commented Jan 15, 2019

main() {}

void func1() {
  func2<String>();
}

void func2<T>() {
  func1();
}

class Class1 {}

class Class2<T> {}

Before:
screenshot 2019-01-15 at 1 47 20 pm

After:
screenshot 2019-01-15 at 1 46 56 pm

The only slight niggle is that if you type a < immediately after some text (without whitespace) it'll also trigger (for ex if (a<10) but we can't really fix that without "real" colouring from the server (which VS Code does not currently support).

@lukepighetti
Copy link
Author

LGTM! Thanks Dan for the hard work. :)

@DanTup
Copy link
Member

DanTup commented Jan 15, 2019

Np, thanks for finding/opening the issues! :-)

I think my email rules need some work - this notification should up with an "Approved" tag because it contained "LGTM" 😆

screenshot 2019-01-15 at 3 18 34 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is bug
Projects
None yet
Development

No branches or pull requests

2 participants