BUG: server does not accurately track skill references for added skills

[EmosewaMC]

Make sure you've done the following:

• I have checked that this issue has not already been reported.

• I have validated that this issue is not a syntax error of either MySQL or SQLite.

• I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

All

Issue Description

currently the server allows the same skill to be equipped in two different slots when in live how this would work is the skill would only be in the first slot that it was equipped to, and then if all items that used that skill were unequipped, or if an equipping item overrides the original skills slot, the other slot would assume the skill.

Reproduction Steps

equip these two items
https://explorer.lu-dev.net/objects/13582 Mole Whacker (via subitem 13934 Molewhacker Left Hand Proxy)
https://explorer.lu-dev.net/objects/5995 Speedy Cap
observe that unequipping the items removes the skill from the wrong slot instead of keeping it there or moving it if another items takes over that slot.

Expected Behavior

2 items with the same skill:

• first equipped item slot is where the skill will reside. unequipping either item will not remove the skill but instead decrement a reference counter by 1.
• equipping another item will remove the skill as usual, but only by decrementing a reference counter. the item will do either of the following based on what happened
  • a new item overrides the slot 2 skills are in means the other slot will take ownership and add skill will need to be sent again for the new slot.
  • a new item overriding the slot not owned by the skill but owned by a reference will result in the new item skill being added and the reference counter going down by 1.

Environment

日本人