Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several buttons are not labeled properly #405

Open
PatchMixolydic opened this issue Jan 15, 2024 · 3 comments
Open

Several buttons are not labeled properly #405

PatchMixolydic opened this issue Jan 15, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@PatchMixolydic
Copy link

PatchMixolydic commented Jan 15, 2024

Describe the bug
The ellipses menu, more buttons button, and exponentiation button do not have accessible labels, rendering them inaccessible to screen reader users. Also, some of the scientific buttons just use their visual label, causing them to be misread (eg. "ln" is announced as "lane" instead of "L N" or "natural log").

To Reproduce
Steps to reproduce the behavior:

  1. Enable TalkBack
  2. Open OpenCalc
  3. Tap and hold, then drag around the calculator
  4. Observe that some buttons are not labeled correctly

Expected behavior
These buttons should be labeled accurately.

Screenshots/videos
(I tried recording a video, but it didn't seem to pick up TalkBack ^^;)

Smartphone (please complete the following information):

  • Device: Nokia XR21
  • OS: Android 13 (Play system update 2023-11-01, security update 2023-12-05)
  • App version: 3.0.0 beta 4
  • Language: English (US) systemwide, English (UK) TTS
@PatchMixolydic PatchMixolydic added the bug Something isn't working label Jan 15, 2024
@inson1
Copy link
Contributor

inson1 commented Jan 16, 2024

I think its feature request not a bug, OpenCalc doesnt yet support talkback, after its done its should be added to feature list

@inson1
Copy link
Contributor

inson1 commented Jan 16, 2024

So we should add contentDescription attribute to all elements that dont work and add translations of those descriptions ( or maybe to all?)
https://developer.android.com/guide/topics/ui/accessibility/principles#label-elements
https://stackoverflow.com/questions/18516516/should-content-description-be-in-multiple-language

Imagebuttons dont work
sections dont work, because they use capitalized characters + I would add "section" to their name (in description)
DEG, RAD, INV dont work because they use capitalized characters

@Darkempire78 Darkempire78 added enhancement New feature or request and removed bug Something isn't working labels Mar 10, 2024
@Darkempire78
Copy link
Owner

Open a Pull request for this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants