Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated and inconsistent dialogs in settings #299

Open
meenbeese opened this issue Jul 29, 2023 · 7 comments
Open

Outdated and inconsistent dialogs in settings #299

meenbeese opened this issue Jul 29, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@meenbeese
Copy link

Describe the bug
Some of the dialog menus used in the settings are outdated and look out of place. They don't follow the Material You color palette and instead have a Material 2 design.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on 'Number of decimal places' or 'Results saved in history'
  3. See the old dialog/fragment

Expected behavior
They should be similar to the dialog menu used for the 'Theme'.

Screenshots/videos
Screenshot_20230728_211853_Calculator_1
Screenshot_20230728_211900_Calculator_1

Smartphone (please complete the following information):

  • Device: Galaxy S20+
  • OS: Android 13
  • Version: 3.0.0-beta3
  • Language: English

Additional context
I saw this issue in only 2 of the 3 menus found in the app which are mentioned above.

@meenbeese meenbeese added the bug Something isn't working label Jul 29, 2023
@Darkempire78 Darkempire78 added enhancement New feature or request and removed bug Something isn't working labels Sep 21, 2023
@Darkempire78
Copy link
Owner

I made a branch to fix that: https://github.com/Darkempire78/OpenCalc/tree/fix-%23299
It's now using the material design 3, but not with the good colors

@meenbeese
Copy link
Author

I made a branch to fix that: https://github.com/Darkempire78/OpenCalc/tree/fix-%23299

It's now using the material design 3, but not with the good colors

Thanks, it is still a clear improvement.

@inson1
Copy link
Contributor

inson1 commented Nov 11, 2023

@Darkempire78 you could also add screenshots. It could save few minutes.

@meenbeese
Copy link
Author

@Darkempire78 you could also add screenshots. You could save as few minutes.

Please be respectful. @Darkempire78 is doing free and volunteer work on an open source project. He literally has zero obligations to you, and if you want luxury treatment you better be donating him a handsome amount before speaking.

@inson1
Copy link
Contributor

inson1 commented Nov 11, 2023

@meenbeese I didnt meant that in any disrespectful way. Just pointing it out. It would be nice. Yes, in future I'm going to donate. + I'm going to provide the screenshots. Here they are.

studio64_xYuFmQhDkV
studio64_Et08wDp60y
studio64_dqaKN2vNi0
studio64_uAsL5O6v32

@meenbeese
Copy link
Author

@meenbeese I didnt meant that in any disrespectful way. Just pointing it out. It would be nice. Yes, in future I'm going to donate. + I'm going to provide the screenshots. Here they are.

I'm sorry if I sounded harsh, but I see this attitude in many people who are new to open source. It only demotivates the developer and harms the community. Your original comment sounded very condescending, so thanks for modifying it @inson1.

@inson1
Copy link
Contributor

inson1 commented Nov 11, 2023

@meenbeese To be clear I wanted to add the screenshots when I added the first comment. So that could changed the meaning.
I didnt change the comment to be nicer, it just souded better.
I didnt meant to sound condescending, its just nice when people share also the screenshots.
So I want luxury treatmeant for everyone from everyone xD People can forget and that is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants