Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galacticraft Slimeling eats wooden hoes #4851

Open
AdamkiX opened this issue Feb 27, 2024 · 5 comments
Open

Galacticraft Slimeling eats wooden hoes #4851

AdamkiX opened this issue Feb 27, 2024 · 5 comments

Comments

@AdamkiX
Copy link

AdamkiX commented Feb 27, 2024

I've decompiled GC slimeling .class file and editted code in such way that it removes wooden hoe from feed item pool. Idk if it is allowed to post edited version of mod here, so I am just informing you about fix. Afterwards I can eventually post EntitySlimeling.class file where mentioned changes were made.

@github-actions github-actions bot added the Status: Blocked For issues ignoring template that completely lack information or other misc reasons label Feb 27, 2024
Copy link

@AdamkiX: hello! 👋

This issue is being automatically closed because it does not follow the issue template.

@sam-kirby
Copy link
Contributor

I don't follow; what is the issue with slimelings? I don't recall one being posted previously.

It's unlikely we can use an edited mod, but it's possible to modify Java bytecode at runtime; the mod https://github.com/DarkPacks/SevPatches is our collection of fixes for other people's mods. You could make a PR there to incorporate your change or you could describe what you've changed in more detail and I'll write the patch.

@AdamkiX
Copy link
Author

AdamkiX commented Feb 27, 2024

SevTech disables wooden hoes and because of that you can't feed slimelings (when wooden hoe rolls from feed item pool). I found one report from years ago, but it was closed and never fixed:
#2066
About fix:
I've decompiled EntitySlimeling.class file with dirtyJOE program. Afterwards I edited method setRandomFavFood in such way that switch case is limited to 9 possible cases then switched wooden hoe (field_151017_I ) with boat (field_151124_az). I will post screenshot of commited changes so you could get some feedback.
obraz
code

Also I've tested random function in test world and it never rolled hoe (everything else was), so I assume that my fix works.

@sam-kirby sam-kirby added Type: Bug Category: Mod For mod or mod interactions Status: Fix in SevPatches Type: Compatibility and removed Status: Blocked For issues ignoring template that completely lack information or other misc reasons labels Feb 28, 2024
@sam-kirby sam-kirby reopened this Feb 28, 2024
@sam-kirby
Copy link
Contributor

I've released a new version of SevPatches that will resolve this issue at runtime; if you add this to your modpack with an unpatched version of GC the slimelings will have prismarine shards added to their diet instead of wooden hoes.

https://github.com/DarkPacks/SevPatches/releases/tag/1.12.0

@sam-kirby sam-kirby changed the title Galacticraft Slimeling potential fix Galacticraft Slimeling eats wooden hoes Feb 28, 2024
@AdamkiX
Copy link
Author

AdamkiX commented Feb 28, 2024

Ok. I'll try it out. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants