Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have colored text to indicate success or failure when dumping #157

Open
ccfman2004 opened this issue Jan 20, 2024 · 4 comments
Open

Have colored text to indicate success or failure when dumping #157

ccfman2004 opened this issue Jan 20, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@ccfman2004
Copy link

Is your feature request related to a problem? Please describe.
With the text being so small on the screen I am having a hard time reading it and since the progress text is all white I find it difficult to see if a dump was successful or there was an error.

Describe the solution you'd like
Change the text color of the finished message to either be green for success or red for error. This would make it much easier to see if the dump was all good or there was an error.

@ccfman2004 ccfman2004 added the enhancement New feature or request label Jan 20, 2024
@PolyCatDev
Copy link

PolyCatDev commented May 5, 2024

Great idea! I'm looking thru the code to see if I can implement this.

@PolyCatDev
Copy link

PolyCatDev commented May 5, 2024

ok. I think I found the part that prints out the output. It's at the bottom of data_transfer_progress_display.cpp

    std::string DataTransferProgressDisplay::GetFormattedSizeString(double size)
    {
        char strbuf[0x40] = {0};
        utilsGenerateFormattedSizeString(size, strbuf, sizeof(strbuf));
        return std::string(strbuf);
    }

I don't know enough about C++ right now to implement this

@DarkMatterCore
Copy link
Owner

@PolyCatDev I'd recommend against doing that, since I've been actively working on the borealis-based UI (and my own borealis fork) as of late. I won't accept any PRs to it for the time being.

This issue most likely refers to PoC builds, which do use console-based text output. Their logic is entirely located within nxdt_rw_poc.c. Feel free to take a look at it if you want.

@PolyCatDev
Copy link

Aha, I see. Thx a lot for the clarification. I hoped it would be as easy as adding a few argumets to render the text a certain color but I was dead wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants