Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a cap for the amount of times /f claim fill recurses #1741

Open
alyphen opened this issue Jun 25, 2023 · 0 comments
Open

Add a cap for the amount of times /f claim fill recurses #1741

alyphen opened this issue Jun 25, 2023 · 0 comments
Labels
bug Something isn't working
Milestone
5.3.3

Comments

@alyphen
Copy link
Member

alyphen commented Jun 25, 2023

It is possible for /f claim fill to cause infinite recursion errors.
We should give the fill method a recursion depth parameter which we decrease each time we recurse so as to prevent trying to fill the whole map.
@alyphen alyphen added the bug Something isn't working label Jun 25, 2023
@dmccoystephenson dmccoystephenson added this to the 5.1.5 milestone Jun 25, 2023
@dmccoystephenson dmccoystephenson modified the milestones: 5.3.1, 5.3.2, 5.3.3 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.3.3
Development

No branches or pull requests
2 participants
@alyphen @dmccoystephenson