Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: Extend '_WD_Window' function by restore option. #515

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sven-Seyfert
Copy link
Contributor

Pull request

Proposed changes

Please see Issue #514 . I described all there. Thanks.

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!

This is simply a reminder of what we are going to look for before merging your code.

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Please see Issue #514 .

What is the new behavior?

Please see Issue #514 .

Influences and relationship to other functionality

Please see Issue #514 .

Additional context

Please see Issue #514 .

System under test

I tested the change on Chrome, Firefox and MSEdge.

@Sven-Seyfert
Copy link
Contributor Author

Review and tests were made by @mlipok , @Danp2 .
What is your point of view regarding this?
See issue #514 😀 . But no stress.

@Danp2 Danp2 linked an issue Apr 28, 2024 that may be closed by this pull request
@Danp2
Copy link
Owner

Danp2 commented Apr 28, 2024

@Sven-Seyfert The code looks fine to me following the revisions, but I haven't tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend _WD_Window() function by _WD_Window($sSession, 'restore')
2 participants