Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow classes to be parametric in other parametric classes (because TypeScript won't) #894

Closed
PatrickJS opened this issue Dec 25, 2023 · 4 comments
Labels
typescript TypeScript compatibility or extensions

Comments

@PatrickJS
Copy link

since TypeScript won't add features for better TypeScript (because it needs to be a JavaScript pattern) maybe we can add features to provide better type DX devs who use Civet
microsoft/TypeScript#1213
^ issue to make this code easier
https://github.com/TanStack/router/blob/beta/packages/react-router/src/link.tsx#L27...L69

@edemaine edemaine added the typescript TypeScript compatibility or extensions label Dec 26, 2023
@edemaine
Copy link
Collaborator

@PatrickJS I don't quite follow the suggestion. Is this something that can be handled by transpilation (as opposed to changing TypeScript's type checker)? (I'm hoping so, given your link to actual TS code doing something similar.) If so, could you give an example of what you have in mind for Civet source and TS output?

@PatrickJS
Copy link
Author

yeah, basically compile to the workaround types but is probably a lot of work

@edemaine
Copy link
Collaborator

Could you show one example of what you'd like to write and what it would transpile to? Currently I see examples of each, but they don't match, so it's difficult to understand the goal.

@PatrickJS
Copy link
Author

yeah I guess the proposed syntax in the ts thread in wasn't exactly finalized and looking it over and the code I guess it was more of if we had this then the code can be refactored. So nothing actionable, my bad. I'll close the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript compatibility or extensions
Projects
None yet
Development

No branches or pull requests

2 participants