Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support h3 v4.0.0 #14

Open
rfc-hv opened this issue Nov 29, 2022 · 1 comment
Open

support h3 v4.0.0 #14

rfc-hv opened this issue Nov 29, 2022 · 1 comment

Comments

@rfc-hv
Copy link

rfc-hv commented Nov 29, 2022

The upcoming h3-py v4.0.0 release is making some breaking changes to the api.

Currently, if the h3 v4.0 prerelease beta is installed with pip install 'h3==4.0.0b2', it fails to integrate with h3pandas:

First issue: h3.h3 has been removed:

venv/lib/python3.10/site-packages/h3pandas/h3pandas.py:15: in <module>
    from h3 import h3
E   ImportError: cannot import name 'h3' from 'h3' (/home/worker/projects/feasibility_workflow/venv/lib/python3.10/site-packages/h3/__init__.py)

https://github.com/uber/h3-py/blob/f8958ac788ea04e2b383c8b859f75a05c3fcb815/src/h3/__init__.py#L6-L7

it looks like this first issue could be fixed by replacing from h3 import h3 with import h3.api.basic_str as h3 in h3pandas code and tests

@bjohnsonUSGS
Copy link

did this ever get resolved? I am having the same issue:

ImportError: cannot import name 'h3' from 'h3'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants