Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously failed ZIP exports will also fail subsequent ZIP exports #9499

Open
jonas-atmire opened this issue Apr 24, 2024 · 1 comment
Open
Assignees
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back help wanted Needs a volunteer to claim to move forward high priority testathon Reported by a tester during Community Testathon tools: export Related to export of data from the system

Comments

@jonas-atmire
Copy link
Contributor

Describe the bug
During the ZIP export through the UI, a temporary directory is created based on the UUID of the eperson doing the export.
If that export fails because of a missing bitstream for example, that temporary directory is never cleared.
Subsequent exports will try to create that directory as well, but that will automatically fail because the directory already exists

To Reproduce
Steps to reproduce the behavior:

  1. Go to a random collection you want to export, a single item is sufficient
  2. Access the DB, and break the bitstream/assetstore linking. (For example by altering the internal_id)
  3. Try the export, it will fail because the bitstream can't be found
  4. Fix any possible issues (For example by changing the internal_id back)
  5. Export again -> it will fail again, with an error like:
2024-04-24 11:38:33.504 ERROR export - 148 @ java.lang.Exception: java.lang.Exception: Directory /home/dspace/dspace/exports/saf-export-bbabd841-98f1-48f6-bb62-d54089931c15.zip/1 already exists!

Expected behavior
If a ZIP export fails in the DSpace codebase, it should either clear up the existing temporary export directory, or a subsequent export should at least not break it.

@jonas-atmire jonas-atmire added bug needs triage New issue needs triage and/or scheduling labels Apr 24, 2024
@tdonohue tdonohue added high priority tools: export Related to export of data from the system testathon Reported by a tester during Community Testathon help wanted Needs a volunteer to claim to move forward and removed needs triage New issue needs triage and/or scheduling labels Apr 24, 2024
@tdonohue
Copy link
Member

Pulling this over to the 8.0 board as this seems to be a high priority bug to fix. Needs a volunteer

@tdonohue tdonohue added the claimed: 4Science 4Science team is working on this issue & will contribute back label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back help wanted Needs a volunteer to claim to move forward high priority testathon Reported by a tester during Community Testathon tools: export Related to export of data from the system
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

3 participants