Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shibboleth special groups are not working #9498

Open
Leano1998 opened this issue Apr 24, 2024 · 1 comment
Open

Shibboleth special groups are not working #9498

Leano1998 opened this issue Apr 24, 2024 · 1 comment
Labels
authentication: Shibboleth Related to authentication via Shibboleth bug needs triage New issue needs triage and/or scheduling

Comments

@Leano1998
Copy link
Contributor

Describe the bug
When you're using shibboleth as authentication method and want to use the special-group functionality, these special groups are not set. I think this might be the same reason why the bug reported in #9226 exits. As reported there, the problem lies in the newly introduced if condition in #9130. I digged a bit deeper into this and found, that if I overwrite the areSpecialGroupsApplicable() method in the ShibAuthentication.java according to the overwrite made in IPAuthentication.java always returning true, it works. I'm still analysing, what is the real cause behind this (so why areSpecialGroupsApplicable() does not return true for shibboleth if needed), but I wanted to post this already.

To Reproduce
Steps to reproduce the behavior:

  1. Activate shibboleth authentication on your backend
  2. Set a group mapping for special-groups as described in the docs.
  3. Login with a user-account via shibboleth, which has the needed affiliation
  4. Check if the special-groups appear in your profile

Expected behavior
The user should be placed in the corresponding special-groups.

Related work

@Leano1998 Leano1998 added bug needs triage New issue needs triage and/or scheduling labels Apr 24, 2024
@Leano1998
Copy link
Contributor Author

It seems as context.getAuthenticationMethod() returns null for the ShibAuthentication in AuthenticationMethod.java:

    public default boolean areSpecialGroupsApplicable(Context context, HttpServletRequest request) {
        return getName().equals(context.getAuthenticationMethod());
    }

@tdonohue tdonohue added the authentication: Shibboleth Related to authentication via Shibboleth label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication: Shibboleth Related to authentication via Shibboleth bug needs triage New issue needs triage and/or scheduling
Projects
Status: 🆕 Triage
Development

No branches or pull requests

2 participants