Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing comments in config/workflow-curation.xml #9495

Open
mwoodiupui opened this issue Apr 23, 2024 · 1 comment
Open

Confusing comments in config/workflow-curation.xml #9495

mwoodiupui opened this issue Apr 23, 2024 · 1 comment
Labels
bug component: workflow Related to approval workflow or configurable workflow configuration Related to out-of-the-box configuration documentation Ticket describes improvements or additions to documentation help wanted Needs a volunteer to claim to move forward

Comments

@mwoodiupui
Copy link
Member

mwoodiupui commented Apr 23, 2024

Describe the bug
The extensive commentary in this file was re-written when I was still confused about the various moving parts of configurable workflow. Several names are incorrect and misleading, and there may be other errors. All of the internal documentation for CWF and workflow curation should be thoroughly examined and corrected.

https://github.com/DSpace/DSpace/blob/main/dspace/config/workflow-curation.xml

@mwoodiupui mwoodiupui added bug needs triage New issue needs triage and/or scheduling labels Apr 23, 2024
@alanorth
Copy link
Contributor

alanorth commented Apr 23, 2024

Thanks @mwoodiupui. At the very least, I noticed these issues in the comments today when setting up a workflow curation task:

  • edit is not a valid step (it should be editstep)
  • step1 is not a valid step (this is used by the example vscan task currently). For what it's worth, it is correct in the DSpace 7 docs
  • archive is not a valid step... the description of this step in config/workflow-curation.xml sounds good, but this step does not exist and never fires (I tried it)

@tdonohue tdonohue added configuration Related to out-of-the-box configuration component: workflow Related to approval workflow or configurable workflow help wanted Needs a volunteer to claim to move forward documentation Ticket describes improvements or additions to documentation and removed needs triage New issue needs triage and/or scheduling labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: workflow Related to approval workflow or configurable workflow configuration Related to out-of-the-box configuration documentation Ticket describes improvements or additions to documentation help wanted Needs a volunteer to claim to move forward
Projects
Status: 🙋 Needs Help / Unscheduled
Development

No branches or pull requests

3 participants