Custom upload steps are hard to implement because the upload
identifier/name is hardcoded in multiple places
#9486
Labels
bug
component: submission
Related to configurable submission system
improvement
needs triage
New issue needs triage and/or scheduling
Describe the issue
When customizing submission forms, we've ended up needing to extend the standard upload step a few times already.
While it's easy to extend
UploadStep
(or related classes), there are multiple spots in the REST & Angular codebase where we expect upload steps to be calledupload
. This makes it impossible to support "standard" and "custom" upload steps within the same repository without modifying more general code:SubmissionSectionHalLinkFactory
doesn't work for upload steps with a name that isn't exactlyupload
. There is also a mixup between the upload step andUploadConfiguration
ID.DataProcessingStep
requires the name of the step and validation to match exactly, which makes it difficult to extend the existion upload step while retaining (part of) the same validation logic.upload
Expected behavior
It should be straight-forward to write and use custom upload steps.
Proposed solution
We want to introduce a
<type extends="...">...</type>
option toitem-submission.xml
to indicate that a step definition extends an existing one.Uing this option, custom upload steps can declare that they should be treated like upload steps.
The text was updated successfully, but these errors were encountered: