Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-9452: Updates query to get collections referenced in the subscribers table #9453

Merged
merged 2 commits into from May 3, 2024

Conversation

nwoodward
Copy link
Contributor

References

Description

This small PR updates the SQL query to get collections with subscribers.

Instructions for Reviewers

  1. Deploy this bug-fix branch
  2. Have at least one subscription to a collection in the subscriptions table
  3. Run [dspace]/bin/dspace healthcheck -e person@example.org
  4. Observe that the health check completes successfully now and lists subscriptions in the output

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
  • If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge. label Apr 10, 2024
@alanorth
Copy link
Contributor

alanorth commented May 3, 2024

Thanks @nwoodward! I tested on DSpace 7.6.1 and it fixes the java.lang.IllegalArgumentException.

@alanorth alanorth added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 3, 2024
@alanorth alanorth added this to the 8.0 milestone May 3, 2024
@alanorth alanorth merged commit a96fe4a into DSpace:main May 3, 2024
22 checks passed
@dspace-bot
Copy link

@alanorth alanorth removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge. bug
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Health check fails because subscriptions table no longer references collections directly
5 participants