Issue-9435 #9436
Merged
Issue-9435 #9436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdonohue
added
bug
1 APPROVAL
|
For some reason the automated GitHub checks have failed to run on this PR. I'm closing it temporarily & reopening to see if that will trigger the checks to run. |
tdonohue
approved these changes
May 3, 2024
There was a problem hiding this comment.
👍 Thanks @Xiqinger ! My apologies for taking so long in reviewing this PR. Today I finally had time to do a detailed review of the suggested changes. I agree that these are all improvements to the current code. I also ran a few basic tests of the modified code and found no changes in behavior.
|
Successfully created backport PR for |
tdonohue
removed
the
port to dspace-7_x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Instructions for Reviewers
check path before mkdirs
Add empty check before call iterator().next()
Before call "Item item = bundles.iterator().next().getItems().iterator().next();",
avoid outputStream write after close
Because "generateBodyMail" has a for loop, it calls "out.close()" in callee "disseminate", then may call "out.write()".