Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icecast 2.3 feed gets stuck offline #1398

Open
doug-hoffman opened this issue Jan 5, 2023 · 0 comments · May be fixed by #1401
Open

Icecast 2.3 feed gets stuck offline #1398

doug-hoffman opened this issue Jan 5, 2023 · 0 comments · May be fixed by #1401

Comments

@doug-hoffman
Copy link
Contributor

During normal operation, if an icecast feed goes offline and encounters an error while attempting to reconnect (mount point in use), it'll believe it's actually connected and give up retrying.

2023-01-05 00:04:30.371 INFO  i.g.d.a.b.AudioStreamingBroadcaster - [East Central Emergency Network Fire and EMS] status: Disconnected  [11GB/24GB 47%]
2023-01-05 00:04:43.690 INFO  i.g.d.a.b.AudioStreamingBroadcaster - [East Central Emergency Network Fire and EMS] status: Disconnected  [8GB/24GB 37%]
2023-01-05 00:04:57.546 INFO  i.g.d.a.b.AudioStreamingBroadcaster - [East Central Emergency Network Fire and EMS] status: Disconnected  [6GB/24GB 28%]
2023-01-05 00:05:11.546 INFO  i.g.d.a.b.AudioStreamingBroadcaster - [East Central Emergency Network Fire and EMS] status: Disconnected  [6GB/24GB 25%]
2023-01-05 00:05:25.563 INFO  i.g.d.a.b.AudioStreamingBroadcaster - [East Central Emergency Network Fire and EMS] status: Disconnected  [5GB/24GB 24%]
2023-01-05 00:05:29.680 INFO  i.g.d.a.b.AudioStreamingBroadcaster - [East Central Emergency Network Fire and EMS] status: Connected  [9GB/24GB 39%]

image

The change below in #1381 seems to indicate the new behavior is intentional, but it is not very desirable for temporary problems. Perhaps it should convey the error without preventing connection attempts.

src/main/java/io/github/dsheirer/audio/broadcast/icecast/IcecastTCPAudioBroadcaster.java:

            //Only set broadcast state to disconnected if it's not already in an error state, to prevent a restart.  We
            //want to preserve the error state that got us here, so the user can see it.
            if(!getBroadcastState().isErrorState())
            {
                setBroadcastState(BroadcastState.DISCONNECTED);
            }

Making a change to the feed then saving allows it to reconnect successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to icecast failure handling doug-hoffman/sdrtrunk
1 participant
@doug-hoffman