Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soil N initialization needs Soil Temperature #278

Open
chporter opened this issue Mar 21, 2023 · 2 comments
Open

Soil N initialization needs Soil Temperature #278

chporter opened this issue Mar 21, 2023 · 2 comments

Comments

@chporter
Copy link
Contributor

Subroutine SoilNi_init.for initializes variables for the SoilNi.for. The first time the subroutine is called, values of ST, soil temperature are zero, and this zero value is used to calculate TFNITY(L) for each soil layer, L. This can result in some slight differences in nitrification rates early in the simulation.

@chporter
Copy link
Contributor Author

Also, PHFACT is 0 first time and 1 second time.
I'm using a test dataset from a user but this is a generic problem.
C:\DSSAT48\RICE\PHUONG\TEST1892.RIX (in case I need to find it later).
Phuong.zip

@chporter
Copy link
Contributor Author

Also, see commit 50d8b20019532dfa1cd6d3b23bb4290b755877d3 where I fixed another initialization error in denitrification. Will be part of my next pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant