Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing calculation of CMINESR vs CMINERT in FOR_SENMOB() #170

Open
palderman opened this issue Dec 15, 2021 · 0 comments
Open

Confusing calculation of CMINESR vs CMINERT in FOR_SENMOB() #170

palderman opened this issue Dec 15, 2021 · 0 comments

Comments

@palderman
Copy link
Contributor

The calculation of CMINESR is different from the calculation of CMINERT in FOR_SENMOB():

CMINERT = CMOBMX * (DTX + DXR57)* PPMFAC *
& (WCRRT - RTWT * PCHORTF)
RTCMINE = MAX(RTSCMOB, CMINERT)
CMINESR = CMOBSR * (DTX + DXR57)* (WCRSR - STRWT * PCHOSRF)
SRCMINE = MAX(SRSCMOB, CMINESR)

Note that the calculation for CMINERT contains PPMFAC while the calculation for CMINESR does not. PPMFAC is the factor that reduces mobilization of carbohydrate/nitrogen reserves due to dormancy. I wonder if it should be the other way around.

It seems to me that dormancy should affect remobilization from the storage organ but not the other tissues. Alternatively, I suppose it might be okay to have it affect root and storage. However, it makes no sense to me that it would affect only root.

Scratch that.

The calculation for CMOBSR already has PPMFAC in it:

CMOBSR = (CMOBSRN + LAIMOBR *
& (CMOBSRX - CMOBSRN)) * PPMFAC

I guess it's not wrong. Just confusing. I think we should consider moving PPMFAC down to the place where CMINESR is calculated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant