Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sec 18.4 (donkey) small suggestion (sign change in definition) #164

Open
murphyk opened this issue Jul 7, 2023 · 0 comments
Open

sec 18.4 (donkey) small suggestion (sign change in definition) #164

murphyk opened this issue Jul 7, 2023 · 0 comments

Comments

@murphyk
Copy link

murphyk commented Jul 7, 2023

A small thing, but I find it confusing that error = (y-pred)/pred, instead of (pred-y)/pred, since one might expect an over estimate (which we want to penalized more) to be a positive error, not a negative error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant