Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventwhen: next button #40

Closed
minaorangina opened this issue Apr 19, 2016 · 2 comments · Fixed by #61
Closed

Eventwhen: next button #40

minaorangina opened this issue Apr 19, 2016 · 2 comments · Fixed by #61

Comments

@minaorangina
Copy link
Contributor

  • does not appear until a new input is added
@minaorangina minaorangina added this to the Sprint 1 milestone Apr 19, 2016
minaorangina added a commit that referenced this issue Apr 20, 2016
@minaorangina
Copy link
Contributor Author

minaorangina commented Apr 20, 2016

Something to do with the way state was being updated.

I tried converting all the nested spreads in the createEvent reducer into Object.assign syntax, and ran into a myriad of problems.

React-Redux is known not to pass down your state properly if you are mutating it in some way.

The way we're using Object.assign seems to be incorrect, chances are we're accidentally mutating.

Have converted back to the old way and the new problems disappear. Still unable to come up with a solution specifically for setEventWhen, as to convert that back to nested spreads brings up the original spread-operator-hell problem.

@minaorangina
Copy link
Contributor Author

Completing #53 should resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant