Hide 1px rectangles for nvd3 graphs. #2529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately nvd3 does display a 1px bar for the value 0: https://github.com/novus/nvd3/blob/master/src/models/discreteBar.js#L198 This works around it but would also make very small values disappear. Fixes DOMjudge#2528.
|
I will close this PR right away it is just for demonstration purposes. It would have the problem mentioned in the commit description, also losing information... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately nvd3 does display a 1px bar for the value 0: https://github.com/novus/nvd3/blob/master/src/models/discreteBar.js#L198
This works around it but would also make very small values disappear.
Fixes #2528.