Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The admin user should default also get a team #2152

Open
vmcj opened this issue Sep 22, 2023 · 3 comments · Fixed by #2171 · May be fixed by #2345
Open

The admin user should default also get a team #2152

vmcj opened this issue Sep 22, 2023 · 3 comments · Fixed by #2171 · May be fixed by #2345

Comments

@vmcj
Copy link
Member

vmcj commented Sep 22, 2023

We already do this in dev instances, but for production we always need the team as we import the jury submissions.

This issue is mostly to describe what would be the disadvantages.

@meisterT
Copy link
Member

The jury role is sufficient (and often personalized) for problem import. So I would not do this but encourage users to create a jury account before doing so.

We could check whether there's a team associated in the import script and ask for confirmation to proceed if not?

@vmcj
Copy link
Member Author

vmcj commented Sep 23, 2023

The jury role is sufficient (and often personalized) for problem import. So I would not do this but encourage users to create a jury account before doing so.

Sounds reasonable

We could check whether there's a team associated in the import script and ask for confirmation to proceed if not?

That should be doable and is a better option.

@vmcj
Copy link
Member Author

vmcj commented Oct 27, 2023

Reopening as the intent doesn't match the code.

Currently a jury member can't upload problems via the GUI (and neither via API see:

)

@meisterT what should be changed? My original question or should we let jury members allow to upload problems? For the last part I would say using API_Writer is the better choice and maybe create a custom role for bapctools so a jury member can't break config easily and only via certain tools?

@vmcj vmcj reopened this Oct 27, 2023
@vmcj vmcj linked a pull request Feb 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants