Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve predict_DO output for pi, oipi, and sim models #330

Open
2 tasks
aappling-usgs opened this issue Mar 8, 2017 · 0 comments
Open
2 tasks

improve predict_DO output for pi, oipi, and sim models #330

aappling-usgs opened this issue Mar 8, 2017 · 0 comments

Comments

@aappling-usgs
Copy link
Contributor

see also #294 (for plots specifically): DO predictions for non-oi-only models require different methods from oi-only models.

  • predict_DO.metab_bayes should make use of err_proc_iid, DO_mod, etc. if these are tracked and stored; otherwise they should give a message or warning describing how close we can get, or not, with the available information
  • predict_DO.metab_model and mm_predict_DO_1ply use err.obs=err.proc=0 right now. they should use errors determined during the model fit, shouldn't they?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant