Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message about both GPP=0 and prediction time period for metab_night >24hr day #328

Open
aappling-usgs opened this issue Feb 27, 2017 · 0 comments

Comments

@aappling-usgs
Copy link
Contributor

You get different messages on predict_metab depending on whether your metab_night inputs are for <=24 hours or >24 hours. Unify these.

For values within the day_start=12, day_end=36 range:

dat <- data_metab("3", "15")
metab(specs=specs(mm_name("night"), day_start=12, day_end=34), data=dat)
for metab_night, GPP estimates are 0 because they're for nighttime only

For values out of the 12-36 range:

dat <- data_metab("3", "15")
metab(specs=specs(mm_name("night"), day_start=10, day_end=36), data=dat)
daily metabolism predictions are for the period from 10 to 34 hours on each date
 (differs from the model-fitting range of 10 to 36 hours)

Make it so that both of the messages ("for metab_night, GPP estimates are 0..." and "daily metabolism predictions are for the period...") appear when both conditions apply.

But see also #327, which could render the message "for metab_night, GPP estimates are 0 because they're for nighttime only" obsolete.

@aappling-usgs aappling-usgs created this issue from a note in Software improvements (Could Do) Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant