4.2.0 CSS issues

[StCyr]

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

4.2.0

Expected behaviour:

branding navbar should display nicely.

Here are proposals to fix the 3 issues listed below:

1. I think the toggle button should have the class "navbar-toggle" and not "navbar-toggler"
2. add "margin-right: 10px" to the "#org-navbar .org-links" selector in file "_navbars.scss"
3. add class "navbar-right" to <ul> "Navigation for organisation admin" in file "_branding.html.erb"

Actual behaviour:

branding navbar shows:

1. A strange toggle button that doesn't seem to do anything
2. No space between 2 <li> in the "org-navbar-menu" element
3. The Admin menu is not right-aligned

[StCyr]

It seems it was some caching, these css issues don't exist anymore here.

Though, I'm seeing a new one, footer's flex-direction is column rather than row:

[StCyr]

damned! that's probably my assets that are not re-created properly... now following precisely what's in https://github.com/DMPRoadmap/roadmap/wiki/Troubleshooting#8-some-or-all-of-my-assets-are-missing...

[StCyr]

well, it's strange though... from what I read, navbar-right doesn't exist anymore in bootstrap 5:

roadmap/app/views/layouts/_footer.html.erb

Line 19 in fc047ac

<ul class="navbar-nav navbar-right">

[StCyr]

ok nevermind, just some branding that I forgot to update :-(