Confusion in feedback_complete email

[StCyr]

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

V4.1.0 customized

Expected behaviour:

feedback_complete email shouldn't be misleading for plans where there's more than 1 phase and might be rewritten to something like "Comments can be found beside the questions of your plan" and phase title always be shown (rather than showing "write plan" when there's only 1 phase) as in DMPbelgium/roadmap@aba6586

If you want to apply DMPbelgium/roadmap@aba6586, maybe other changes are needed:

root@dmponline:/opt/roadmap-test# grep -Ri "write plan" app/ lib/ db/ public/
app/javascript/src/locale/en_GB/app.js:      'Write Plan': ['plan'],
app/javascript/src/locale/fr_FR/app.js:      'Write Plan': ['plans'],
app/javascript/src/locale/es/app.js:      'Write Plan': ['plans'],
app/javascript/src/locale/en_US/app.js:      'Write Plan': ['plan'],
app/javascript/src/locale/de/app.js:      'Write Plan': ['plans'],
app/views/user_mailer/feedback_complete.html.erb:  <%= _("%{commenter} has finished providing feedback on the plan  \"%{link_html}\". Comments can be found in the 'Write plan' tab on the right side of the page (Guidance/Comments).").html_safe % {
app/views/org_admin/phases/preview.html.erb:        <%= link_to _('Write plan'), '#', class: 'preview-tab' %>
app/views/phases/_overview.html.erb:      <a href="<%= edit_plan_path(plan_id, phase_id: phase.id) %>" class="btn btn-default pull-right"><%= _('Write plan') %></a>
app/views/phases/edit.html.erb:<% title "#{plan.title} - Write plan" %>
app/views/plans/_navigation.html.erb:        <%= (phases.size > 1 ? phase.title : _('Write Plan')) %>
app/controllers/notes_controller.rb:# Controller for the Comments section of the Write Plan page
app/controllers/plans_controller.rb:# Controller for the Write plan and create plan pages

Actual behaviour:

In feedback_complete email, it's written that: "Comments can be found in the 'Write plan' tab on the right side of the page (Guidance/Comments)." (

roadmap/app/views/user_mailer/feedback_complete.html.erb

Line 5 in 8a0d0fb

<%= _("%{commenter} has finished providing feedback on the plan \"%{link_html}\". Comments can be found in the 'Write plan' tab on the right side of the page (Guidance/Comments).").html_safe % {

)

We have a customized version of V4.1.0, so I'm not 100% sure, but, doesn't the "Write plan" tab only show when there's only 1 phase?

If so, the feedback_complete email is misleading for plans where there's more than 1 phase