Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chats should return Connection not Optional<Connection> #668

Open
csmith opened this issue Feb 26, 2016 · 0 comments
Open

Chats should return Connection not Optional<Connection> #668

csmith opened this issue Feb 26, 2016 · 0 comments

Comments

@csmith
Copy link
Member

csmith commented Feb 26, 2016

Query and Channels currently return an Optional (probably because that's what a WindowModel returns). They will always have a connection, so that doesn't really make sense.

Once the WindowModel is separated (see #89) Chat should be changed to return a plain Connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant